Add new django tutorial #4869
Add new django tutorial #4869
Conversation
…amples into tutorial/django-run
google-cla
bot
added
the
cla: yes
There was a problem hiding this comment.
Thanks for the PR.
Is there any more background to this sample? Will it be included under cloud.google.com/run? If not, maybe we can host the sample in a community tutorial folder with our other cloud run tutorials.
Is the tutorial original? I didn't review the code as it doesn't seem to be originally authored.
CC @grayside
run/django/README.md
Outdated
| This repository is an example of how to run a [Django](https://www.djangoproject.com/) | ||
| app on Google Cloud Run (fully managed). | ||
|
|
||
| The Django application used in this tutorial is the [Writing your first Django app](https://docs.djangoproject.com/en/3.0/#first-steps), after completing [Part 1](https://docs.djangoproject.com/en/3.0/intro/tutorial01/) and [Part 2](https://docs.djangoproject.com/en/3.0/intro/tutorial02/)). |
There was a problem hiding this comment.
Are we 100% sure that Google authored this code and we're able to claim it under this repo's license? It seems like this tutorial should be hosted on Django's website/repo and not here.
There was a problem hiding this comment.
I followed the pattern from the kubernetes and appengine samples.
product-auto-label
bot
added
the
samples
|
Linting was failing since typechecks are currently configured to include typechecking noxfile.py itself, which is copied per workspace from ~/noxfile-template.py. " Happy to cherrypick these comments to a different branch and rebase this branch, for code cleanliness. (This branch also needs a squash, maybe, not seeing anything in AUTHORING_GUIDE about such things. |
Description
Implements new Django tutorial with integration testing. (Internal cl/309679445)
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)